Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:select): wrong sort in group option #5063

Merged
merged 1 commit into from
Apr 17, 2020
Merged

fix(module:select): wrong sort in group option #5063

merged 1 commit into from
Apr 17, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Apr 17, 2020

Fixes #5011

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 17, 2020

This preview will be available after the AzureCI is passed.

vthinkxie
vthinkxie approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit af39d5f into NG-ZORRO:master Apr 17, 2020
@wenqi73 wenqi73 deleted the fix-select branch April 17, 2020 07:59
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@wenqi73
fix(module:select): wrong sort in group option (NG-ZORRO#5063)
75eb75c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie approved these changes

Assignees

@simplejason simplejason

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select with groups not working correctly with ngfor in group and ngfor in option
3 participants
@wenqi73 @vthinkxie @simplejason